search

jsuarezruiz / Xamanimation

Xamarin Forms Animation Library
MIT License
458 stars 57 forks source link

Number of movements in ShakeAnimation #15

Open AmorimRob opened 5 years ago

AmorimRob commented 5 years ago

Hello Javier!

Before everything, I want to thank you for this amazing lib!

I'm using the lib in my project to animate some entries with Shake Animation when user inserts invalid values. Talking with the UX professional in my team, she asked me if it is possible to control the number of movements in the shake animation.

Looking at the code, I saw that the class ShakeAnimation have the property Movement but it is private and I can't change it.

What do you think about creating a bindable property for this? With this, the user will be able to control the number of movements in the animation

Thank you!

jsuarezruiz commented 5 years ago

Well, it seems like a very good idea!. I will include it as soon as I can. Feel free to send a PR yourself if you want ;).

AmorimRob commented 5 years ago

Nice! I'm working on this :D