search

jsuereth / sbt-in-action-examples

Source code examples for the book "sbt in Action"
144 stars 54 forks source link

typo + fix a possible NaN in Logic.matchLikelihood #18

Closed ericsebesta closed 9 years ago

ericsebesta commented 9 years ago

I'm not sure if you'll want this change, but i felt that I should point it out. If you take this pull request to Chapter2, I can replicate it in the other chapter areas - since it appears in all of them.

matthewfarwell commented 9 years ago

The book is currently in pre-production, so we don't want to change any code at the minute. Once it goes into production, we'll have a look at this sort of thing.

ericsebesta commented 9 years ago

Oh, I totally understand. It's just a proposal in the "github way" - i.e. feel free to dismiss it or ignore it for a while. Best luck on launching the book - I'm looking forward to it!

jsuereth commented 9 years ago

Thanks @esebesta if I hadn't said so before. We really appreciate it.

ericsebesta commented 9 years ago

Happy to help. I anxiously await the full book! :)