search

jsuereth / sbt-in-action-examples

Source code examples for the book "sbt in Action"
144 stars 54 forks source link

Improvements and fixes by dusank #7

Closed dusank closed 9 years ago

dusank commented 10 years ago

I am currently in the process of reviewing SBT in Action and will be pushing any improvements and/or fixes onto this branch.

=Dušan

dusank commented 10 years ago

Added fix for issue https://github.com/jsuereth/sbt-in-action-examples/issues/8 in Chapter3 - Chapter8.

jsuereth commented 10 years ago

Generally all of these changes look great! The "organization in ThisBuild" vs. in the common project is one of "learning gate" issues in the book. As people are learning concepts, we're not quite ready to throw "ThisBuild" or "Global" at them (with descriptions) in chapter 4. I'll look into where that can go in the text.

I may merge this and fix manually, but am going to ping @matthewfarwell on what he may have to say.

dusank commented 9 years ago

The problem with not using in ThisBuild is how to keep the multi-project implementation both consistent and DRY at the same time.

As a reader I would definitely prefer to learn the best way of accomplishing things even though it encompasses a forward reference to a later chapter to fully understand, to being presented an inferior incomplete solution that, even though it is easier to grasp, will have to be changed and reexplained later to become "good enough" to be used "for real". I feel its easier and preferable in this case to learn once thoroughly than learn oversimplified and have to relearn.

Of course, YMMV.

jsuereth commented 9 years ago

SO I'm going to merge this request,but I'm still on the fence with the version setting in ThisBuild. I actually consider it better practice use sbt-git and versionWithGit which accomplishes the DRY principle, albeit by using the git-tag mechanism to determine the version number.

In any case, thanks much for the fixes. We'll be sorting the book examples out shortly.