search

jsumners / alfred-emoji

Alfred workflow for searching and copying emoji
741 stars 32 forks source link

Add better support for multi-word searches #18

Closed rmm5t closed 6 years ago

rmm5t commented 6 years ago

Closes #17

It's functional as it stands, but I've got to head out for a bit (be back later today). There's room to noodle on this though.

rmm5t commented 6 years ago

My inclination is that this is a much slower search. But it looks to be the simplest effective method.

It's no slower for the majority of searches that arrive with just one keyword.

But, in coding this up, I realized the opportunity to further optimize the search in general. Right now, we run over two passes of the emoji. I'm planning to refactor that into just one pass while also gaining better knowledge between matches of the emoji name and the emoji aliases. The side effect of this would also mean being able to remove the Set logic to unique-ify the results in the end.

I'll try to add a stacked PR on top of this one later today.

rmm5t commented 6 years ago

Changed my mind a bit. I'll merge this into master first. Then submit another PR.

Let's just hold off on a new versioned release until the next PR comes.

jsumners commented 6 years ago

Not a problem. Take your time.