search

jsumners / alfred-emoji

Alfred workflow for searching and copying emoji
741 stars 32 forks source link

Implement basic ordering for emoji results #68

Closed devnoname120 closed 2 years ago

devnoname120 commented 2 years ago

Close https://github.com/jsumners/alfred-emoji/issues/65

Emojis that match on name are on top VS emojis that match on keywords.

Before: image

After: image

devnoname120 commented 2 years ago

Needs to be updated due to merged PR: #66

devnoname120 commented 2 years ago

Reconciliating the changes was a big pain, and now coverage doesn't pass. I'm giving up and staying on my fork.

devnoname120 commented 2 years ago

@jsumners By the way, what would you think about reducing the coverage to e.g. 80%? I think it's a big deterrent to productivity and I don't think its brings significant benefits to aim for 100%.

jsumners commented 2 years ago

There needs to be a clear demonstration as to why 100% is not attainable.

devnoname120 commented 2 years ago

@jsumners Disagree. There needs to be a clear demonstration that introducing a 100% code coverage requirement is providing enough benefits that it justifies the significantly reduced productivity. 100% coverage encourages useless ad-hoc tests. Goodhart's law at play.

I may do a hard fork and probably rewrite the code from the ground up because the 100% coverage requirement and the search design choices don't suit me. Also I believe I can have significantly better performances by reducing the warm-up time tremendously.