search

jsumners / alfred-emoji

Alfred workflow for searching and copying emoji
741 stars 32 forks source link

Add genpack step #75

Closed miharekar closed 2 years ago

miharekar commented 2 years ago

Probably required since #69.

But I had to do that in order for build to succeed.

jsumners commented 2 years ago

npm run build merely runs ./build.sh, which includes:

https://github.com/jsumners/alfred-emoji/blob/8ada3e88b47bb89b87242c74756bc858ac9bac56/build.sh#L25-L26

We shouldn't need to add "npm run genpack" to the instructions. It looks like the actual problem is a webpack problem (ugh, I hate that we have to rely on that tool):

> webpack
> webpack

assets by status 1.86 KiB [cached] 1 asset
./src/emoji.js 959 bytes [built] [code generated]
./src/search.js 3.38 KiB [built] [code generated]
./src/utils.js 154 bytes [built] [code generated]

ERROR in ./src/search.js 3:18-46
Module not found: Error: Can't resolve './emoji.pack.json' in '/Users/jsumners/Projects/oss/alfred-emoji/src'
resolve './emoji.pack.json' in '/Users/jsumners/Projects/oss/alfred-emoji/src'
  using description file: /Users/jsumners/Projects/oss/alfred-emoji/package.json (relative path: ./src)
    Field 'browser' doesn't contain a valid alias configuration
    using description file: /Users/jsumners/Projects/oss/alfred-emoji/package.json (relative path: ./src/emoji.pack.json)
      no extension
        Field 'browser' doesn't contain a valid alias configuration
        /Users/jsumners/Projects/oss/alfred-emoji/src/emoji.pack.json doesn't exist
      .js
        Field 'browser' doesn't contain a valid alias configuration
        /Users/jsumners/Projects/oss/alfred-emoji/src/emoji.pack.json.js doesn't exist
      .json
        Field 'browser' doesn't contain a valid alias configuration
        /Users/jsumners/Projects/oss/alfred-emoji/src/emoji.pack.json.json doesn't exist
      .wasm
        Field 'browser' doesn't contain a valid alias configuration
        /Users/jsumners/Projects/oss/alfred-emoji/src/emoji.pack.json.wasm doesn't exist
      as directory
        /Users/jsumners/Projects/oss/alfred-emoji/src/emoji.pack.json doesn't exist
 @ ./src/emoji.js 4:15-34

webpack 5.67.0 compiled with 1 error in 358 ms
miharekar commented 2 years ago

Ah, well, that's out of scope of my knowledge. I just know what fixed it for me 😅

jsumners commented 2 years ago

Thank you for the contribution. It showed a problem in the build process. This PR is superseded by https://github.com/jsumners/alfred-emoji/pull/77