jsumners / alfred-emoji

Alfred workflow for searching and copying emoji
739 stars 31 forks source link

Missing emoji aliases #78

Closed jefftriplett closed 2 years ago

jefftriplett commented 2 years ago

I couldn't tell if this was related to #76, but it looks like common aliases might have been dropped in the last update.

An example is searching for coffee which brings up brown "brown heart" 🤎 and "coffin" ⚰️.

TIL that it's labeled as "hot beverage" which search can't quite narrow down with either "hot beverage" or "hotbeverage". I can eventually get there by searching for "beverage" finding it.

Anyways, not a huge deal, but passing it along just in case this wasn't intended.

jsumners commented 2 years ago

Aliases are defined in https://unicode.org/emoji/charts/emoji-list.html and imported here through https://github.com/muan/emojilib. As such, we do not maintain the list of aliases. We'd need upstream to fill in the gaps and release a new version.

jsumners commented 2 years ago

I think emojilib maintains the aliases manually. I also think the maintainer is tired of maintaining the library (completely understandable). Before they released v3, I investigated parsing the atrocious Unicode data sets and building my own data to use in this application. I may need to revisit that.

jefftriplett commented 2 years ago

Thanks for the quick reply and the reference. I think I might have found the 1 in a million where it was accidently moved to the 🤎 . https://github.com/muan/emojilib/pull/199 It might be fixed in a future update from the looks of things.

berters commented 2 years ago

@jsumners It definitely seems like something is off - you can see my example of "pray" to find U+1F64F - which used to work but can no longer be found.

Screenshot 2022-02-03 at 08 51 26 .

jsumners commented 2 years ago

@berters please reread the thread.

berters commented 2 years ago

@berters please reread the thread.

My apologies, seems like it's down to emojlib then.

rmm5t commented 2 years ago

Some of these aliases are being fixed in emojilib as we speak: https://github.com/muan/emojilib/commits/main/dist/emoji-en-US.json

cafesanu commented 2 years ago

First, thanks for this alfred workflow @jsumners . I love it.

Now, I get it the emojilib is the one keeping the keywords, but something changed lately and now results are way of. For example, I use the bee emoji a lot, I used to do emoji bee and it would be the first result in the list, now it's a cow.

Let's compare what emojilib has vs the results:

image image image

Now, let's be more exact. These are the emojis have the string in bee in emojilib. And this is the order or precedence I would expect them to have base on the position in the array:

As you can see, the string bee is in position 0 for the 🐝 emoji, vs in position 1 for 🐮 emoji. I would expect that the strings with higher position within the arrays would have more precedence. Just like, when I type :bee here in github, I get the bee First.

In conclusion, I would expect the following order based on emojilib:

Position 0 to 5 (in any order since they all share position 0?).

"🐝": [ "honeybee", "animal", "insect", "nature", "bug", "spring", "honey" ], "🐞": [ "lady_beetle", "animal", "insect", "nature", "ladybug" ], "🍺": [ "beermug", "relax", "beverage", "drink", "drunk", "party", "pub", "summer", "alcohol", "booze" ], "🍻": [ "clinkingbeermugs", "relax", "beverage", "drink", "drunk", "party", "pub", "summer", "alcohol", "booze" ], "🍻": [ "clinkingbeer_mugs", "relax", "beverage", "drink", "drunk", "party", "pub", "summer", "alcohol", "booze" ], "🪲": [ "beetle", "insect" ],

Position 5 to 6 (in any order since they all share position 1).

"🐮": [ "cow_face", "beef", "ox", "animal", "nature", "moo", "milk" ], "🐄": [ "cow", "beef", "ox", "animal", "nature", "moo", "milk" ],

Position 7 to 8 (in any order since they all share position 3).

"🐂": [ "ox", "animal", "cow", "beef" ], "🍔": [ "hamburger", "meat", "fast food", "beef", "cheeseburger", "mcdonalds", "burger king" ],

Thanks!

jefftriplett commented 2 years ago

I'm going to go ahead and close my own issue. My main issue I was seeing was aliases not working that appear to be in emojilib (see https://github.com/muan/emojilib/blob/63532198d03123e5b75aa348bc00f6f36f18aac7/dist/emoji-en-US.json#L4804 for an example of my "emoji coffee" showing up blank example).

I think the scope of comments has drifted to search relevance more than aliases not showing up. Feel free to re-open if you want.