search

jsumners / node-activedirectory

ActiveDirectory is an Node.js ldapjs client for authN (authentication) and authZ (authorization) for Microsoft Active Directory with range retrieval support for large Active Directory installations. Originally forked from gheeres/node-activedirectory.
MIT License
52 stars 43 forks source link

Missing default for opts in groupExists #97

Closed verenagbr closed 1 year ago

verenagbr commented 2 years ago

Hi,

I tried groupExists function which mentions that opts is not needed. But if not present it fails.

Think there is a missing default like in findGroup method.

See: https://github.com/jsumners/node-activedirectory/blob/8ff17bdf366a2d6926879ba06fbe84ba0171c01f/lib/activedirectory.js#L583

Thanks in advance

jsumners commented 2 years ago

Would you like to send a Pull Request to address this issue? Remember to add unit tests.