jsun969 / react-hook-form-antd

๐Ÿ“‹๐Ÿœ Master your Ant Design form with React Hook Form! ็”จ React Hook Form ๆ‹ฟๆไฝ ็š„ Ant Design ่กจๅ•๏ผ
https://npm.im/react-hook-form-antd
MIT License
61 stars 10 forks source link

wrap antd form items with rhf controller component #5

Closed jakub-szewczyk closed 1 year ago

jakub-szewczyk commented 1 year ago

This PR fixes the following issues: #2 #3 as well as some other problems related to form items not rerendering in spite of values being changed under the hood in react-hook-form. For example setValue now works as intended allowing to dynamically change form data.

I also had to to upgrade antd version inside the demo app. Otherwise the checkbox component doesn't behave as expected (doesn't toggle, value stays fixed).

jsun969 commented 1 year ago

TY @jakub-szewczyk ! Sry I'm quite busy recently. I'll review it ASAP!

jsun969 commented 1 year ago

thx for your AWESOME job @jakub-szewczyk ! I'll upgrade some dependencies this week and merge this PR soon!

jsun969 commented 8 months ago

@all-contributors please add @jakub-szewczyk for code

allcontributors[bot] commented 8 months ago

@jsun969

I've put up a pull request to add @jakub-szewczyk! :tada: