fix: allow override default onFieldChange

jsun969 / react-hook-form-antd

📋🐜 Master your Ant Design form with React Hook Form! 用 React Hook Form 拿捏你的 Ant Design 表单！

https://npm.im/react-hook-form-antd

MIT License

58 stars 10 forks source link

Closed ahmedrowaihi closed 2 months ago

ahmedrowaihi commented 3 months ago

allow override default Field.onChange

this could be used to manually set Upload or any other fields on-change

for example, developer can use, setValue from useFormContext manually to alter form state

example for Upload from antd

<FormItem
   valuePropName="fileList"
   overrideFieldOnChange={(info) => {
      setValue('images', info.fileList);
     }}
 />

close #83

ahmedrowaihi commented 3 months ago

couldn't run tests


Error: Cannot find module 'react-dom'

ahmedrowaihi commented 3 months ago

ah, it was due to my workspace

I will fix it

ahmedrowaihi commented 3 months ago

@jsun969 couldn't write a test for this case to mimick file upload

but I confirm that the affect is only happening if you add overrideFieldOnChange so merging this won't create issues to existing behavior

and the new behavior is working on real case

jsun969 commented 3 months ago

couldn't write a test for this case to mimick file upload

That's fine. I'll test it later and merge this. Thx a lot for your help!

ahmedrowaihi commented 2 months ago

@jsun969 hey boss, is this good ? I have a task on my work that is waiting for this PR :'D