search

jsunconf / 2019.jsunconf.eu

0 stars 3 forks source link

feat(contriboot): adjust styling #50

Closed klyrr closed 5 years ago

klyrr commented 5 years ago

I updated contriboot that the styling isn't in that application anymore but here in the main app.

herschel666 commented 5 years ago

why does the styling live in this repo, while the actual contriboot app lives in a different one? and — regarding the fact, that contriboot is completely renderer on the client-side — would it make sense to integrate the styles into the app with CSS modules, styled-components, etc??

klyrr commented 5 years ago

good point about the CSS modules. I also have thought about this.

But I guess one problem we have are the styles in this application because most of them style tags and not classes. And they will mess with the styles for the contriboot elements

herschel666 commented 5 years ago

But I guess one problem we have are the styles in this application because most of them style tags and not classes. And they will mess with the styles for the contriboot elements

that's too bad! we should fix this soonish.