Chore: 🤖 upgrade to angular v17

whernebrink commented 7 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Which Transloco package(s) will this feature affect?

Don't know / other

Is your feature request related to a problem? Please describe

No response

Describe the solution you'd like

Transloco to support Angular 17. Nx is already supporting, if that would matter.

Describe alternatives you've considered

Additional context

No response

I would like to make a pull request for this feature

No

whernebrink commented 7 months ago

@NetanelBasal How should this be done? Is it just an nx migration that needs to be ran? I could try helping out, but would be great with some pointers. We really would like to migrate and try angular 17 for our application and transloco is the only thing that is preventing us right now. :)

beloveddd commented 7 months ago

I have the same issue with Transloco and Angular 17 :(

alexdabast commented 6 months ago

@whernebrink What is the error when you want to use it with angular 17 ? if it is only the version issue when you try to npm i ? Then my first guess is that this repo just need to run a angular 17 migration This will basically bump all angular version to 17 in all package.json file https://github.com/ngneat/transloco/blob/ab57b376ba11cfa380405fe0fc88a2751f0184cd/libs/transloco/package.json#L43

alexdabast commented 6 months ago

I just created a brand new angular 17 app installed @ngneat/transloco and it works fine So what's the issue @beloveddd and @whernebrink

shaharkazaz commented 6 months ago

@alexdabast Thank you for asking the exact question I wanted to ask and for the PR 🙂 What is the issue here? Transloco works with Angular 17.

hernebrink commented 6 months ago

@shaharkazaz, thanks for getting back to this. Indeed it works! Not sure why we experienced an issue with our upgrade. I've tested with 6.0.1 and it works. Thanks. :)

shaharkazaz commented 6 months ago

@whernebrink can you share what was the issue you faced?

hernebrink commented 6 months ago

@shaharkazaz, unfortunately not. I was filing the issue on behalf of a team mate who was the one trying. Probably not a "real" issue I suppose. Node version, old node_module, or other local thing. Sorry for not having a better answer.

alexdabast commented 6 months ago

I don't know then if my PR is still required @shaharkazaz. I guess it would be nice to have the repo updated to the latest version. I have push all the changes that you asked for the PR btw

theguidingstar commented 5 months ago

I am getting this error after migration to Angular 17 @alexdabast Anything I'm doing wrong here??

node_modules/@ngneat/transloco/lib/transloco.providers.d.ts:23:21 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("@angular/core")' call instead.

23     provide: import("@angular/core").InjectionToken<Content>;
                       ~~~~~~~~~~~~~~~

node_modules/@ngneat/transloco/lib/transloco.service.d.ts:1:27 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("@angular/core")' call instead.

1 import { OnDestroy } from '@angular/core';
                            ~~~~~~~~~~~~~~~

node_modules/@ngneat/transloco/lib/transloco.service.d.ts:10:21 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("@angular/core")' call instead.

10 import * as i0 from "@angular/core";

jsverse / transloco