chore: 🤖 upgrade to nx17

jsverse / transloco

🚀 😍 The internationalization (i18n) library for Angular

https://jsverse.github.io/transloco/

MIT License

2.01k stars 195 forks source link

chore: 🤖 upgrade to nx17 #734

Closed alexdabast closed 3 months ago

alexdabast commented 9 months ago

Upgrading to nx17 using npx nx migrate latest

✅ Closes: #731

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/ngneat/transloco/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ x] Other... Please describe: Nx upgrade version

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

I did not manually bump any devPeer in libs folder as I don't think it is required to do that

stackblitz[bot] commented 9 months ago

Run & review this pull request in StackBlitz Codeflow.

shaharkazaz commented 9 months ago

@alexdabast Thanks for the PR! Note that the lint & tests are failing. Regarding the lint, I think some warnings are now errors, can you adjust the lint to act as before the update? Also, can you run the Angular 17 migration on the playground?

alexdabast commented 9 months ago

@shaharkazaz I will look into the tests failing however what do you mean by migration the playground ? It looks to me that the playground is using angular 17 as you can use the new syntaxe for example and it is working fine

and the code

shaharkazaz commented 9 months ago

I'll clarify, I meant running the new syntax migration so that the playground code will use it ☺️

alexdabast commented 9 months ago

@shaharkazaz I have run the migration and did some test seems ok Regarding the lint and test now angular workspace are by default standalone so I force the workspace creation to standalone:false and removed the standalone:true on the standalone test.

Also had to replace runSchematicAsync by runSchematic and remove the conversion to promise as it returns now directly a promise

shaharkazaz commented 9 months ago

@alexdabast

Lint: Please set @typescript-eslint/no-explicit-any as a warning and not an error, and remove all the unused var cases, that should take care of that.
Tests: Seems like a beforeAll hook is failing, try to run it locally and debug the issue, any chance you need to update from master?

theguidingstar commented 8 months ago

Any news on this? When it's going to be merged and released?

jontze commented 6 months ago

Thanks for your work on this PR, @alexdabast. Do you still have the time to push this forward?

If not, I would be happy to support you in completing the remaining points :)

shaharkazaz commented 3 months ago

The repository is already using nx v17