Update notebook.min.js to include updated marked syntax

jsvine / notebookjs

Render Jupyter/IPython notebooks on the fly, in the browser. (Or on the command line, if you'd like.)

MIT License

274 stars 48 forks source link

Update notebook.min.js to include updated marked syntax #41

Closed srmibextesting closed 1 year ago

srmibextesting commented 2 years ago

Based on the marked.js usage documents (https://marked.js.org/#usage), it is necessary to call the function as markdown.parse() instead of just markdown(). I believe this was effective as of version 4 of marked.js.

jsvine commented 1 year ago

Thank you for flagging this, @srmibextesting! I've implemented this fix (in a manner a bit more idiomatic/idiosyncratic to the library) in https://github.com/jsvine/notebookjs/commit/3496f63d316993909944b7e08e906e8b020fa4c5 and added you to the list of thanks in README.md.