Closed samkit-jain closed 3 years ago
Merging #294 into develop will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## develop #294 +/- ##
========================================
Coverage 97.47% 97.47%
========================================
Files 10 10
Lines 1190 1190
========================================
Hits 1160 1160
Misses 30 30
Impacted Files | Coverage Δ | |
---|---|---|
pdfplumber/page.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 04fd56a...b132d45. Read the comment docs.
Great catch, thanks! Merging.
This PR fixes #293. Was uncaught in https://github.com/jsvine/pdfplumber/commit/04fd56ac405fd753e7f9c826ce103459013f2e71 probably because other methods may have called
.objects
before the call to.dedup_chars()
.To resolve the issue, I replaced the usage of
._objects
with.objects
. If only._objects
is to be used, can add a simpleself.objects
statement likeCan also do the same in the
__init__()
method instead as well.NOTE: I added a new PDF
issue-71-duplicate-chars-2.pdf
(thanks to @Fleur09 for sharing in #292) as it has repeating characters.