Closed samkit-jain closed 3 years ago
I wasn't sure if the PR required the changelog to be updated. @jsvine How do you build the package before publishing it to pip? I think we can include that as a build verification step to the GitHub Actions workflow.
Merging #363 (8fa6eb0) into develop (a019517) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #363 +/- ##
========================================
Coverage 98.25% 98.25%
========================================
Files 10 10
Lines 1203 1203
========================================
Hits 1182 1182
Misses 21 21
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a019517...e6225b4. Read the comment docs.
Result of #362, this PR enforces the Python version to be a minimum of 3.6 for pip to install the package.
Thanks, and good idea! Merging.
I wasn't sure if the PR required the changelog to be updated.
I don't think it does, since we've already made clear that 3.5 support is deprecated, but thanks for asking.
@jsvine How do you build the package before publishing it to pip? I think we can include that as a build verification step to the GitHub Actions workflow.
python setup.py build sdist
Feel free to open a PR with that, or I can add it to my todo list.
Feel free to open a PR with that, or I can add it to my todo list.
Opened PR #365
Result of #362, this PR enforces the Python version to be a minimum of 3.6 for pip to install the package.
Did some black formatting along the way as well.