search

jsvine / pdfplumber

Plumb a PDF for detailed information about each char, rectangle, line, et cetera — and easily extract text and tables.
MIT License
6.57k stars 659 forks source link

Pass kwds args to Table.extract from Page.extract_table #415

Closed trifling closed 3 years ago

trifling commented 3 years ago

The extract_table method of the Page class does not honour text tolerance settings. Pass the relevant parameters from the table_settings parameter to the Table.extract method.

codecov[bot] commented 3 years ago

Codecov Report

Merging #415 (8e6b6fd) into stable (ecc9e8e) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 8e6b6fd differs from pull request most recent head 536b8d9. Consider uploading reports for the commit 536b8d9 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           stable     #415   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          10       10           
  Lines        1207     1208    +1     
=======================================
+ Hits         1186     1187    +1     
  Misses         21       21
Impacted Files Coverage Δ
pdfplumber/page.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ecc9e8e...536b8d9. Read the comment docs.

jsvine commented 3 years ago

Given the simplicity of this change and a desire to get this into 0.5.28, I've merged this, added the test, and updated the contributor list and changelog. Thanks for catching this, @trifling, and thanks for flagging the necessary additions, @samkit-jain.