search

jswaff / prophet

Prophet chess engine
4 stars 0 forks source link

xboard move protocol #41

Closed dave-kaye closed 2 years ago

dave-kaye commented 2 years ago

Hello,

I have been looking at a chess GUI and tried Prophet 4.1 using it.

The GUI sends only xboard protocol 1 move strings, and you are running some xboard protocol 2 commands. Therefore, Prophet fails to run, giving invalid command errors.

Specifically, the sent move in xboard protocol 1 is: MOVE where the MOVE is a 4 to 5 character string in coordinate algebraic notation.

The move in xboard protocol 2 is allowed to be (but is not required to be): usermove MOVE where the MOVE is a 4 to 5 character string in coordinate algebraic notation. In addition, the MOVE is allowed to be (but not required to be) in SAN notation.

I looked at your code, and saw an easy way to add the xboard protocol 1 notation. After you have looked at the input string for keywords, you give an error message. I inserted a simple input string size check for 4-5 characters, which will call a function xboard_move(). This is a duplicate of your xboard_usermove() function, with the initial few lines of code modified to match the new move structure. I could have added a check for proper rank and file characters in the first 4 characters, and a pawn promotion character in the 5th character, but your code does that later on and I was keeping this simple.

I attached a patch file so you could see what I had to do so I can use Prophet. You know your code, and could find a more elegant way of doing this.

Please consider expanding the Prophet codebase to allow for the xboard protocol 1 to allow additional chess GUIs to work with your chess engine.

Thank you.

p.s. the diff file will not load in GitHub, so made as txt file, hope it still is OK move.diff.txt

jswaff commented 2 years ago

Hi Dave. Just noticed this... I will review ASAP. I appreciate the patch.

dave-kaye commented 2 years ago

 

Thank you.   

Sent: Sunday, March 06, 2022 at 4:02 PM From: "James Swafford" @.> To: "jswaff/prophet" @.> Cc: "dave-kaye" @.>, "Author" @.> Subject: Re: [jswaff/prophet] xboard move protocol (Issue #41)

 

Hi Dave. Just noticed this... I will review ASAP. I appreciate the patch.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>

jswaff commented 2 years ago

HI Dave. I've added your code into the master branch, so it will be part of future releases. Thanks for the patch.

I will look into allowing contributors to branch and create PRs to make the process a little easier on both sides.

dave-kaye commented 2 years ago

 

Thank you.  

Sent: Saturday, April 02, 2022 at 10:31 AM From: "James Swafford" @.> To: "jswaff/prophet" @.> Cc: "dave-kaye" @.>, "Author" @.> Subject: Re: [jswaff/prophet] xboard move protocol (Issue #41)

 

HI Dave. I've added your code into the master branch, so it will be part of future releases. Thanks for the patch.

I will look into allowing contributors to branch and create PRs to make the process a little easier on both sides.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>