search

jswanner / DontF-WithPaste

Google Chrome extension that prevents the blocking of pasting into input fields
https://chrome.google.com/webstore/detail/dont-fuck-with-paste/nkgllhigpcljnhoakjkgaieabnkmgdkb
MIT License
818 stars 66 forks source link

Breaks image paste on Facebook #64

Closed alexboutros closed 6 years ago

alexboutros commented 6 years ago

Chrome version: 65.0.3325.181 (Official Build) (64-bit

Don't Fuck With Paste Version: 2.3

Cannot paste images from clipboard in new posts or in messenger.

jswanner commented 6 years ago

When you are on Facebook, what color is the extension's icon (blue or grey)?

If blue, what rules does you have setup? Shortcut to see them all, open a tab to the following: chrome://extensions/?options=nkgllhigpcljnhoakjkgaieabnkmgdkb (or open the extension preference page, click "Details" for this extension, then "Extension options").

maximbaz commented 6 years ago

Uff, I experienced the same issue on github for a week now, apparently the extension was active because I had an empty rule (and it matched all websites?). Not sure how I ended up with the empty rule, the extension doesn't allow creating an empty one, maybe it happened during an upgrade.

jswanner commented 6 years ago

Ah, right, an empty rule would match anything. The following evaluates to true:

(new RegExp('')).test('anything')

I should be able to make some changes to better prevent empty rules from being created, and can definitely skip evaluating empty patterns.

jswanner commented 6 years ago

I just released version 2.4 which includes fixes for empty rules.

jswanner commented 6 years ago

I believe I've fixed the issue @maximbaz brought up.

@alexboutros, if that didn't fix your problem, feel free to reopen this issue.