search

jswanner / knockoutjs-rails

The Knockout.js JavaScript library ready for the Rails asset pipeline.
MIT License
53 stars 18 forks source link

No need to set upper limit on railties dependencies #12

Closed rosenfeld closed 10 years ago

rosenfeld commented 10 years ago

Make it work with Rails 4.1.0

jswanner commented 10 years ago

@rosenfeld thanks for the PR.

Since this gem depends on Rails' asset pipeline, there's no way for me to know that the asset pipeline won't change at some point in the future that will break this gem at this version.

But, Rails 4.1 and beyond should still be supported. Decided to continue to follow Rails' own gems that use the asset pipeline, and go with ">= 3.1", "< 5.0".

I've release 3.1.0.1, which is 3.1.0 of knockout, but with the new railties dependency declaration.

rosenfeld commented 10 years ago

thanks