jswebtools / language-ecmascript

Haskell library: ECMAScript parser, pretty-printer and additional tools
Other
46 stars 26 forks source link

Update for GHC 7.10.1, <$> is now in Prelude #61

Closed alanz closed 9 years ago

achudnov commented 9 years ago

Hi Alan, The build fails in ghc 7.4: https://travis-ci.org/jswebtools/language-ecmascript/jobs/56741011. I guess it will require CPP to do neatly it neatly --- or update dependencies to preclude building on 7.4. I don't have time to figure that out right now. If you do, could you, please, update the PR accordingly? Also, I'm not able to test on GHC 7.10 as of yet.

alanz commented 9 years ago

I don't have travis configured on my repo, but it passes the tests on my box with GHC 7.10.1

achudnov commented 9 years ago

You can see the build failure via the link I've provided previously. But, basically ---and as expected--- the build fails on the versions of GHC where Prelude doesn't export the <$> operator you're trying to hide.

alanz commented 9 years ago

I meant it did not build in my fork, but did in yours, anc can now merge cleanly. See https://travis-ci.org/jswebtools/language-ecmascript/builds/56750945

achudnov commented 9 years ago

Oh I haven't noticed you've added another commit. Yeah, looks good: merging.

achudnov commented 9 years ago

Do you need this on Hackage soon?

alanz commented 9 years ago

When its convenient to you, I am building from my fork at the moment.

On Wed, Apr 1, 2015 at 11:12 PM, Andrey Chudnov notifications@github.com wrote:

Do you need this on Hackage soon?

— Reply to this email directly or view it on GitHub https://github.com/jswebtools/language-ecmascript/pull/61#issuecomment-88633144 .

bergmark commented 9 years ago

wl-pprint doesn't build on 7.10 yet. https://github.com/haskell-infra/hackage-trustees/issues/14

bergmark commented 9 years ago

wl-pprint-1.2 has been released with GHC 7.10 support.

achudnov commented 9 years ago

Thanks, Adam! I can't test it with 7.10 right now as neither Travis CI, nor my dev machine have that version installed. Are you in a rush for 7.10 support?

bergmark commented 9 years ago

I don't need it since I have a fork on our private hackage, but this package is one of only three in the Silk dependency tree that aren't 7.10 compatible yet ;-)

achudnov commented 9 years ago

Fixed and released in 0.17.0.1