search

jswhit / pyspharm

Automatically exported from code.google.com/p/pyspharm
Other
33 stars 18 forks source link

Fortran update #7

Closed DWesl closed 5 months ago

DWesl commented 3 years ago

My compiler complained about a rank mismatch, so I copied the declarations from the called functions to the calling functions.

Edit: Refocused to be just the Fortran updates, since I can do a lot of packaging things. I'll put those changes in a new PR soon.

alaniwi commented 8 months ago

I saw this after creating a pull request to fix the same problem. See: https://github.com/jswhit/pyspharm/pull/12

It probably doesn't make a big difference which one is merged, but the comment lines suggest that the theta array should in fact be of length l rather than 1, hence the choice in the above PR.

https://github.com/jswhit/pyspharm/blob/ba80d44636bb0d0df1e4f2bdb74465b08c71c724/src/alf.f#L203-L211

DWesl commented 5 months ago

Superceeded by #12