search

jswoboda / ISRSpectrum

Code that will create an ISR spectrum with multiple ion species.
MIT License
7 stars 2 forks source link

fix isrutilities link, line endings #5

Closed drhirsch closed 7 years ago

drhirsch commented 7 years ago

This is the actual fix. I mistyped in setup.py. And the line endings were goofing up the self test

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 51.587% when pulling 16cc3864df5c27d11406006ebea2838767e40cbe on scienceopen:master into 82b5273d9786d4bf858c8574e68d957b1af7134b on jswoboda:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 51.587% when pulling 16cc3864df5c27d11406006ebea2838767e40cbe on scienceopen:master into 82b5273d9786d4bf858c8574e68d957b1af7134b on jswoboda:master.

drhirsch commented 7 years ago

This time the self-tests passed, on my previous PR they had failed before merge

jswoboda commented 7 years ago

I added pathlib2 to the requirements.txt. Everything started passing on my branch after that along with adding a couple of lines to the travis file. Is this method a more correct way of doing that?

drhirsch commented 7 years ago

This is a better fix because it's not relying on special commands that an end user would also have to type.

This pull request