Closed BillyLevin closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.03%. Comparing base (
a08fbcc
) to head (a08fbcc
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Attempt to fix #966
The rule no longer errors if the existence of label text cannot be determined. The criteria for not being able to determine whether the text exists are, for each child of the label:
I don't think this accounts for every case, but hopefully a good starting point
I followed the convention already used by making the new parameters for
mayHaveAccessibleLabel
optional, even though they're not. I assume that was to make it easier to write the unit tests. Happy to change that though if you'd like