jsx-eslint / eslint-plugin-jsx-a11y

Static AST checker for a11y rules on JSX elements.
MIT License
3.38k stars 637 forks source link

Allow `menuitemradio` and `menuitemcheckbox` on <li> #950

Closed khiga8 closed 3 months ago

khiga8 commented 1 year ago

Fixes: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/896

Currently, the jsx-a11y/no-noninteractive-element-to-interactive-role rule flags <li role="menuitemradio"> and <li role="menuitemcheckbox">. I don't think these should be flagged, especially given we allow <li role="menuitem">.

Conflicting recommendations:

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.02%. Comparing base (0d5321a) to head (ec87ead).

:exclamation: Current head ec87ead differs from pull request most recent head c0733f9

Please upload reports for the commit c0733f9 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #950 +/- ## ======================================= Coverage 99.02% 99.02% ======================================= Files 105 105 Lines 1636 1642 +6 Branches 579 578 -1 ======================================= + Hits 1620 1626 +6 Misses 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.