search

jsx-eslint / eslint-plugin-jsx-a11y

Static AST checker for a11y rules on JSX elements.
MIT License
3.38k stars 637 forks source link

remove array-includes #964

Closed dulmandakh closed 10 months ago

dulmandakh commented 10 months ago

let's remove support for very old version of Node.js, and array-includes polyfill. And after a while, let's release a new major version.

codecov[bot] commented 10 months ago

Codecov Report

Merging #964 (c252de0) into main (1635dcc) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         105      105           
  Lines        1628     1628           
  Branches      578      578           
=======================================
  Hits         1612     1612           
  Misses         16       16
Files Coverage Δ
src/rules/control-has-associated-label.js 100.00% <100.00%> (ø)
src/rules/interactive-supports-focus.js 97.05% <100.00%> (ø)
...s/no-interactive-element-to-noninteractive-role.js 100.00% <100.00%> (ø)
...rc/rules/no-noninteractive-element-interactions.js 100.00% <100.00%> (ø)
...s/no-noninteractive-element-to-interactive-role.js 100.00% <100.00%> (ø)
src/rules/no-noninteractive-tabindex.js 97.36% <100.00%> (ø)
src/rules/no-redundant-roles.js 100.00% <100.00%> (ø)
src/util/isInteractiveElement.js 100.00% <100.00%> (ø)
src/util/isInteractiveRole.js 100.00% <100.00%> (ø)
src/util/isNonInteractiveElement.js 100.00% <100.00%> (ø)
... and 2 more
ljharb commented 10 months ago

No, let's not, thanks. Same discussion as in the other repo. This would be a breaking change immediately, and removing a polyfill isn't a valuable enough change to be worth the insanely high cost of a semver-major.