jsx-eslint / eslint-plugin-jsx-a11y

Static AST checker for a11y rules on JSX elements.
MIT License
3.38k stars 637 forks source link

include eslint@9 in peerDependencies #994

Closed yuheiy closed 5 days ago

yuheiy commented 2 months ago

v6.9.0 supports Flat Config, but an error occurs during installation because peerDependencies does not include eslint@9. This PR adds "^9" to peerDependencies.

socket-security[bot] commented 2 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eslint@9.5.0 environment Transitive: filesystem, unsafe +13 4.37 MB eslintbot

View full report↗︎

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.03%. Comparing base (882bd4d) to head (c257e65). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #994 +/- ## ======================================= Coverage 99.03% 99.03% ======================================= Files 107 107 Lines 1651 1651 Branches 581 581 ======================================= Hits 1635 1635 Misses 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ljharb commented 2 months ago

That's not sufficient to support eslint 9; see #978. Please leave this PR open, since I'll now have to repurpose it when eslint 9 support is actually possible.

In the meantime, simply do not yet upgrade to eslint 9, until all of your plugins support it explicitly.

andreyevyk commented 2 weeks ago

With the publication of the version v6.9.0, is it now possible to include eslint@9 in peerDependencies?

ljharb commented 2 weeks ago

@andreyevyk nope, not yet, see #978.

burtek commented 5 days ago

@ljharb what about now?

michaelfaith commented 5 days ago

This is already covered by https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/pull/1009

burtek commented 5 days ago

@michaelfaith true :facepalm: I think it's time for me to go to bed

ljharb commented 5 days ago

Indeed; obsoleted by #1009.