jsx-eslint / eslint-plugin-react

React-specific linting rules for ESLint
MIT License
8.97k stars 2.77k forks source link

[Fix] `prop-types`: handle nested forwardRef + memo #3679

Closed developer-bandi closed 7 months ago

developer-bandi commented 8 months ago

Fix #3521

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9f4b2b9) 97.74% compared to head (c1c273c) 97.74%.

:exclamation: Current head c1c273c differs from pull request most recent head 88f7f09. Consider uploading reports for the commit 88f7f09 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3679 +/- ## ======================================= Coverage 97.74% 97.74% ======================================= Files 132 132 Lines 9409 9420 +11 Branches 3449 3456 +7 ======================================= + Hits 9197 9208 +11 Misses 212 212 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ljharb commented 8 months ago

With the latest rebase, some tests are failing. Can you update to this commit and take a look?

developer-bandi commented 8 months ago

@ljharb yes, so I fix the failed test code but almost code is changed. so may be reivew is nessesary

and some Tests are fail because node install fail. i don't know why it is fail. please tell me hint to fix it. (and Automatic Rebase)

developer-bandi commented 8 months ago

You don't have to worry about the automatic rebase check. The PR now lacks any tests, is that intentional?

no, it is not intentional. it's my mistake. perhaps i did pull at local codebase, that test code is deleted. so i revert all test code already exist