search

jsx-eslint / eslint-plugin-react

React-specific linting rules for ESLint
MIT License
8.86k stars 2.75k forks source link

Add JSDoc type annotations #3731

Open y-hsgw opened 2 months ago

y-hsgw commented 2 months ago

I have added type annotations and fixed associated type errors.

y-hsgw commented 2 months ago

I have addressed this in pull request #3732 and will proceed to close this one. I'll handle the areas requiring type changes separately.

ljharb commented 2 months ago

I would prefer to update this PR with those changes rather than abandoning it.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 94.89796% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 97.69%. Comparing base (4467db5) to head (e2c3497).

:exclamation: Current head e2c3497 differs from pull request most recent head b392497. Consider uploading reports for the commit b392497 to get more accurate results

Files Patch % Lines
lib/rules/jsx-curly-spacing.js 83.33% 1 Missing :warning:
lib/rules/jsx-equals-spacing.js 50.00% 1 Missing :warning:
lib/rules/jsx-space-before-closing.js 50.00% 1 Missing :warning:
lib/rules/no-deprecated.js 92.85% 1 Missing :warning:
lib/rules/no-unused-class-component-methods.js 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3731 +/- ## ========================================== - Coverage 97.71% 97.69% -0.03% ========================================== Files 133 133 Lines 9470 9507 +37 Branches 3469 3494 +25 ========================================== + Hits 9254 9288 +34 - Misses 216 219 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.