search

jsx-eslint / eslint-plugin-react

React-specific linting rules for ESLint
MIT License
8.97k stars 2.77k forks source link

[Fix] `jsx-no-leaked-render`: invalid report if left side is boolean #3746

Closed akulsr0 closed 4 months ago

akulsr0 commented 4 months ago

Fixes #3719

akulsr0 commented 4 months ago

Can we rerun the failing tests once?

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.58%. Comparing base (4467db5) to head (61d4a8a). Report is 2 commits behind head on master.

:exclamation: Current head 61d4a8a differs from pull request most recent head d97e3ed. Consider uploading reports for the commit d97e3ed to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3746 +/- ## ========================================== - Coverage 97.71% 97.58% -0.14% ========================================== Files 133 133 Lines 9470 9480 +10 Branches 3469 3475 +6 ========================================== - Hits 9254 9251 -3 - Misses 216 229 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akulsr0 commented 4 months ago

Not sure why the tests are failing here, @ljharb can you please have a look here once?

ljharb commented 4 months ago

Don't worry about the Automatic Rebase check, and the code coverage check isn't a "failure" as much as an indicator that this PR drops the coverage percentage.