search

jsx-eslint / eslint-plugin-react

React-specific linting rules for ESLint
MIT License
8.97k stars 2.77k forks source link

[Fix] jsx-newline: jsx-newline breaking with comments #3747

Closed akulsr0 closed 2 months ago

akulsr0 commented 4 months ago

Closes #3573

akulsr0 commented 4 months ago

Can we rerun the failing test once?

ljharb commented 4 months ago

yep, looks like a fluke; reran.

akulsr0 commented 4 months ago

Bumping this up!

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.76%. Comparing base (417e1ca) to head (9d6aa68). Report is 1 commits behind head on master.

:exclamation: Current head 9d6aa68 differs from pull request most recent head 7722f49

Please upload reports for the commit 7722f49 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3747 +/- ## ========================================== - Coverage 97.79% 97.76% -0.04% ========================================== Files 134 134 Lines 9613 9614 +1 Branches 3486 3486 ========================================== - Hits 9401 9399 -2 - Misses 212 215 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akulsr0 commented 4 months ago

I remember the same issue mentioned in #3573 was happening for me too, which got fixed by this. But now I am unable to reproduce it :(