mdjermanovic
commented
1 month ago CI with ESLint v9 fails here:
******> npm ls >/dev/null
npm error code ELSPROBLEMS
npm error invalid: eslint@9.3.0 /home/runner/work/eslint-plugin-react/eslint-plugin-react/node_modules/eslint
eslint-plugin-react@7.34.1 /home/runner/work/eslint-plugin-react/eslint-plugin-react
├── @babel/core@7.24.5
├── @babel/eslint-parser@7.24.5
├── @babel/plugin-syntax-decorators@7.24.1
├── @babel/plugin-syntax-do-expressions@7.24.1
├── @babel/plugin-syntax-function-bind@7.24.1
├── @babel/preset-react@7.24.1
├── @types/eslint@7.2.10
├── @types/estree@0.0.52
├── @types/node@4.9.5
├── @typescript-eslint/parser@5.62.0
├── array-includes@3.1.8
├── array.prototype.findlast@1.2.5
├── array.prototype.flatmap@1.3.2
├── array.prototype.toreversed@1.1.2
├── array.prototype.tosorted@1.1.3
├── aud@2.0.4
├── babel-eslint@10.1.0
├── doctrine@2.1.0
├── es-iterator-helpers@1.0.19
├── eslint-config-airbnb-base@15.0.0
├── eslint-doc-generator@1.7.1
├── eslint-plugin-eslint-plugin@5.5.1
├── eslint-plugin-import@2.29.1
├── eslint-remote-tester-repositories@1.0.1
├── eslint-remote-tester@3.0.1
├── eslint-scope@3.7.3
├── eslint@9.3.0 invalid: "^3 || ^4 || ^5 || ^6 || ^7 || ^8" from the root project
├── espree@3.5.4
├── estraverse@5.3.0
├── glob@10.3.7
├── istanbul@0.4.5
├── jackspeak@2.1.1
├── jsx-ast-utils@3.3.5
├── ls-engines@0.8.1
├── markdownlint-cli@0.32.2
├── minimatch@3.1.2
├── mocha@5.2.0
├── npmignore@0.3.1
├── object.entries@1.1.8
├── object.fromentries@2.0.8
├── object.hasown@1.1.4
├── object.values@1.2.0
├── prop-types@15.8.1
├── resolve@2.0.0-next.5
├── semver@6.3.1
├── sinon@7.5.0
├── string.prototype.matchall@4.0.11
├── typescript-eslint-parser@20.1.1
└── typescript@3.9.10
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-05-19T19_26_11_701Z-debug-0.log
got status code 1
1Seems I'll have to update peerDependencies in root package.json in this PR to make it reach the test step?
codecov[bot]
ljharb
socket-security[bot]
DysektAI
Refs https://github.com/jsx-eslint/eslint-plugin-react/issues/3699
Adds utility to automatically transform tests to ESLint v9 format when ESLint v9 is used.
I have all tests still passing with ESLint v8 locally (we'll see what happens with the older versions in CI).
Around ~500 tests are failing with ESLint v9 due to new RuleTester checks. Some because of problems in tests (e.g., duplicate tests or missing some now-mandatory test case properties), some because of problems in rules (e.g., no-op options schema or unsubstituted placeholders in messages). I'll try to fix that in separate commits in this PR.
Also fixed bugs that ESLint v9 RuleTester caught in rules
jsx-closing-bracket-locationandno-invalid-html-attribute.