search

jsx-eslint / eslint-plugin-react

React-specific linting rules for ESLint
MIT License
9k stars 2.77k forks source link

Rule proposal: disallow children on DOM element tags when contentEditable #713

Open lencioni opened 8 years ago

lencioni commented 8 years ago

React will issue a warning in dev if you use contentEditable with children. This can be suppressed with suppressContentEditableWarning.

https://github.com/facebook/react/blob/85dcbf83/src/renderers/dom/shared/ReactDOMComponent.js#L187-L193

This should be easy enough to enforce for most cases with a linter rule.

Bad:

<div contentEditable>
  Children
</div>

Good:

<div contentEditable />
<div contentEditable suppressContentEditableWarning>
  Children
</div>
lencioni commented 8 years ago

Name: dom-elements-no-content-editable-with-children?