windows bat file to build JSX

jsx / JSX

JSX - a faster, safer, easier JavaScript

http://jsx.github.io/

MIT License

1.46k stars 102 forks source link

windows bat file to build JSX #319

Open shibukawa opened 10 years ago

kazuho commented 10 years ago

Thank you for the PR.

Code in the PR states that https://code.google.com/p/msysgit/ is required. My understanding is that make is bundled with msysgit. Is there a reason not to use make?

shibukawa commented 10 years ago

msysgit doesn't include development tools. make is not in the distribution (I checked 1.8.4 and 1.9.0).

kazuho commented 10 years ago

Thank you for checking that.

I am not inclined to merge this PR as is due to the following reasons.

having copy-pasted code for various environments is not a good idea
proposed PR only covers a small portion of the build process; it does provide a way to run the equivalent of make test or make bootstrap-server etc., and thus IMO is a incomplete to be considered as a development environment for Windows

My understanding is that users may install jsx on Windows using npm and they can also install make to develop JSX. Please correct me if I am wrong.

shibukawa commented 10 years ago

I made this script to test issue #316. If the fix would be published (it seems not to be published yet), the priority weill be low.

It is a first version. In future, I will find other Winows issues, I will create other target too.

kazuho commented 10 years ago

Understood, though I would advise to implement the tests as part of the test suite (instead of copy-pasted build script) so that we could automatically detect regressions.

Regarding the next release, I would like to wait for #309 get finished, since I do not want to occasionally introduce incompatibilities in the toolchain (and we have already merged #313 that does this).