Closed kazuho closed 10 years ago
@wasabiz do you have any idea? The test case seem to address some kind of problem within the inlining optimizer but I could not find changes to the compiler source that corresponds to the test.
@kazuho No, I don't. In fact I've never even touched around the inliner at all. Presumably, jsx's inliner is presently almost broken because nobody takes care of and maintained it, we'd better do a bunch of refactoring against it now.
Fixed in commit 380b864.
Well, Inline optimizer is used in many of the projects including the JSX compiler itself (the npm-packaged version of JSX is optimized using --release
and thus is using the inline optimizer), and I do care of it.
If
--optimize inline
is set, the_Main.main
function of t/run/356.expand-lhs-value.jsx gets compiled into the code below, which accesses an undeclared globaln
.