jsxc / prosody-cloud-roster

MIT License
5 stars 0 forks source link

Error message #3

Open chriscroome opened 6 years ago

chriscroome commented 6 years ago

I have this in the /var/log/prosody/prosody.log:

Jul 16 14:31:56 mod_bosh        error   Traceback[bosh]: ...rosody/modules/mod_roster_cloud/mod_roster_cloud.lua:43: attempt to concatenate local 'username' (a table value)
stack traceback:
        ...rosody/modules/mod_roster_cloud/mod_roster_cloud.lua:43: in function '?'
        /usr/lib/prosody/util/events.lua:78: in function </usr/lib/prosody/util/events.lua:74>
        (tail call): ?
        /usr/lib/prosody/core/rostermanager.lua:132: in function 'rm_load_roster'
        /usr/lib/prosody/core/sessionmanager.lua:188: in function 'sm_bind_resource'
        /usr/lib/prosody/modules/mod_saslauth.lua:310: in function '?'
        /usr/lib/prosody/util/events.lua:78: in function </usr/lib/prosody/util/events.lua:74>
        (tail call): ?
        /usr/lib/prosody/core/stanza_router.lua:152: in function </usr/lib/prosody/core/stanza_router.lua:63>
        (tail call): ?
        ...
        /usr/lib/prosody/net/http/server.lua:128: in function 'success_cb'
        /usr/lib/prosody/net/http/parser.lua:177: in function 'feed'
        /usr/lib/prosody/net/http/server.lua:159: in function 'onincoming'
        /usr/lib/prosody/net/server_event.lua:608: in function </usr/lib/prosody/net/server_event.lua:557>
        [C]: in function 'loop'
        /usr/lib/prosody/net/server_event.lua:751: in function </usr/lib/prosody/net/server_event.lua:750>
        [C]: in function 'xpcall'
        /usr/bin/prosody:400: in function 'loop'
        /usr/bin/prosody:431: in main chunk
        [C]: ?

In the prosody.cfg.lua file I have:

modules_enabled = {

        -- Other specific functionality
                "roster_cloud" -- Nextcloud groups in XMPP https://github.com/jsxc/prosody-cloud-roster
}

-- mod_roster_cloud
-- https://github.com/jsxc/prosody-cloud-roster
roster_cloud_url = ""
roster_cloud_secret = ""

I wasn't sure what to use for the roster_cloud_url and roster_cloud_secret, see #2.

MarcelWaldvogel commented 6 years ago

Yes, the values should be the ones from #2. Do you have them in place or did you leave them empty?

(If empty, please fill them and try again.)

chriscroome commented 6 years ago

Thanks, I have added them but I still get this on login in the /var/log/prosody/prosody.log:

Jul 16 17:12:04 bosh7cae1254-3dd8-4e5c-9507-59a8ad966ad0        info    Authenticated as admin@example.org.uk
Jul 16 17:12:05 boshf799ae90-1c17-42f5-a830-f52d5b8669cc        info    BOSH client disconnected
Jul 16 17:12:05 mod_bosh        info    Disconnecting client, <stream:error> is: <body xmlns:stream='http://etherx.jabber.org/streams' type='terminate' condition='remote-stream-error' xmlns='http://jabber.org/protocol/httpbind'><stream:error><conflict xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xmlns='urn:ietf:params:xml:ns:xmpp-streams'>Replaced by new connection</text></stream:error></body>
Jul 16 17:12:05 mod_bosh        error   Traceback[bosh]: ...rosody/modules/mod_roster_cloud/mod_roster_cloud.lua:43: attempt to concatenate local 'username' (a table value)
stack traceback:
        ...rosody/modules/mod_roster_cloud/mod_roster_cloud.lua:43: in function '?'
        /usr/lib/prosody/util/events.lua:78: in function </usr/lib/prosody/util/events.lua:74>
        (tail call): ?
        /usr/lib/prosody/core/rostermanager.lua:132: in function 'rm_load_roster'
        /usr/lib/prosody/core/sessionmanager.lua:188: in function 'sm_bind_resource'
        /usr/lib/prosody/modules/mod_saslauth.lua:310: in function '?'
        /usr/lib/prosody/util/events.lua:78: in function </usr/lib/prosody/util/events.lua:74>
        (tail call): ?
        /usr/lib/prosody/core/stanza_router.lua:152: in function </usr/lib/prosody/core/stanza_router.lua:63>
        (tail call): ?
        ...
        /usr/lib/prosody/net/http/server.lua:128: in function 'success_cb'
        /usr/lib/prosody/net/http/parser.lua:177: in function 'feed'
        /usr/lib/prosody/net/http/server.lua:159: in function 'onincoming'
        /usr/lib/prosody/net/server_event.lua:608: in function </usr/lib/prosody/net/server_event.lua:557>
        [C]: in function 'loop'
        /usr/lib/prosody/net/server_event.lua:751: in function </usr/lib/prosody/net/server_event.lua:750>
        [C]: in function 'xpcall'
        /usr/bin/prosody:400: in function 'loop'
        /usr/bin/prosody:431: in main chunk
        [C]: ?
sualko commented 6 years ago

I'm sorry, but I have currently no time to look into this. Please ping me in a week.

chriscroome commented 6 years ago

Thanks @sualko no rush, I have commented the module out for now.

MarcelWaldvogel commented 5 years ago

(ping) :smile:

DevelAngel commented 5 years ago

I think the error comes from the new event system used in roster-load hook function, see mod_groups.lua for comparison.

Nov 01 13:49:54 startup info    Hello and welcome to Prosody version hg:5f51710d7c1e
...
Nov 01 13:49:59 rostermanager   debug   load_roster: asked for: angelos@drossos.de                                                                                      
Nov 01 13:49:59 rostermanager   debug   load_roster: loading for new user: angelos@drossos.de                                                                           
Nov 01 13:49:59 runnerbj_SAIFP  debug   changed state from ready to error (ready)                                                                                       
Nov 01 13:49:59 c2s55b5ba1620   error   Traceback[c2s]: ...rosody/modules/mod_roster_cloud/mod_roster_cloud.lua:43: attempt to concatenate local 'username' (a table valu
e)                                                                                                                                                                      
stack traceback:                                                                                                                                                        
        ...rosody/modules/mod_roster_cloud/mod_roster_cloud.lua:43: in function '?'                                                                                     
        /usr/lib64/prosody/util/events.lua:79: in function </usr/lib64/prosody/util/events.lua:75>                                                                      
        (tail call): ?                                                                                                                                      
        /usr/lib64/prosody/core/rostermanager.lua:135: in function 'rm_load_roster'
        /usr/lib64/prosody/core/sessionmanager.lua:191: in function 'sm_bind_resource'
        /usr/lib64/prosody/modules/mod_saslauth.lua:310: in function '?'
        /usr/lib64/prosody/util/events.lua:79: in function </usr/lib64/prosody/util/events.lua:75>
        (tail call): ?
        /usr/lib64/prosody/core/stanza_router.lua:152: in function 'core_process_stanza'
        /usr/lib64/prosody/modules/mod_c2s.lua:276: in function 'func'
        /usr/lib64/prosody/util/async.lua:126: in function </usr/lib64/prosody/util/async.lua:124>

I use the trunk version of prosody, commit id 5f51710d7c1e, which is newer than prosody version 0.10.2.

A simple patch can be found here in my gentoo portage overlay repository.

MarcelWaldvogel commented 5 years ago

Thanks for the patch! This is the event system used in Prosody 0.11?