search

jsxgraph / moodle-filter_jsxgraph

moodle plug-in for JSXGraph
https://jsxgraph.org
2 stars 6 forks source link

hidden custom js inclusion to external site. #9

Closed danmarsden closed 5 years ago

danmarsden commented 5 years ago

You are hosting some JS on your site that can be unexpectedly included in the users site. http://jsxgraph.uni-bayreuth.de/distrib/jsxgraphcore-0.99.5.js

You should remove this or make it very clear in the readme/description of your plugin.

andreas-web commented 5 years ago

As explained in my comment on issue #10, the inclusion of external code is essential, as it is necessary to fulfill a user's request. In our README file this possibility of integration from an external site is already explained (see https://github.com/jsxgraph/moodle-filter_jsxgraph#admin-settings). In addition, it is made clear in the administration of the filter that an external server is requested with the appropriate settings. screenshot

Since version 0.99.5 is only available on our server (http://jsxgraph.uni-bayreuth.de) the link can not be removed.

If necessary, further information can be entered in our README file.

andreas-web commented 5 years ago

To fix this issue 0.99.5 is no longer supported in the filter.