jsydow / swp-dv-ws2010-osm-1

Automatically exported from code.google.com/p/swp-dv-ws2010-osm-1
0 stars 0 forks source link

Order the members of all classes by visibility #81

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
To improve the readability of the source code, all variables, inner classes and 
methods of classes should be ordered by their name (ascending). Eclipse can do 
this automatically via "Source" > "Sort members".

It is possible to configure Eclipse to always sort members when saving a file 
("Properties" > "Java Editor" > "Save actions" > "Configure" > "Code 
Organizing"). The sort order can be configured, unfortunately not in a 
per-project manner but only for the whole workspace ("Preferences" > "Java" > 
"Members Sort Order"). I highly recommend to sort members in the same category 
by visibility.

Original issue reported on code.google.com by thi...@inf.fu-berlin.de on 21 Mar 2011 at 5:21

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r735.

Original comment by Skud...@googlemail.com on 21 Mar 2011 at 7:18

GoogleCodeExporter commented 9 years ago
This issue is not yet fixed. The existing source code has not been ordered yet.

Original comment by thi...@inf.fu-berlin.de on 21 Mar 2011 at 8:27

GoogleCodeExporter commented 9 years ago
We do have to admit that there is 
[http://code.google.com/p/swp-dv-ws2010-osm-1/source/browse/trunk/TraceBook/src/
tracebook/core/data/db/TagDbOpenHelper.java?r=698 one file] we have not ordered 
yet (because of some wonky forward declarations after reordering, gotta get 
some consultation), but all other source files have been reordered in r734, the 
commit before the closing one.

Chances are you just have looked at r735 and decided that nothing else had been 
done before. For now, we can agree on not closing this issue until the very 
last file has been reordered.

Original comment by Skud...@googlemail.com on 21 Mar 2011 at 10:51

GoogleCodeExporter commented 9 years ago
WontFix because java does not allow using static fields before declaration.

Original comment by js.schrifterz@googlemail.com on 22 Mar 2011 at 1:10