jsymonkj / pwi

Automatically exported from code.google.com/p/pwi
0 stars 0 forks source link

Using "labels" localization breaks permalink feature #89

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. configure a page using the "labels" parameter to translate interface 
2. configure it to use the permalink feature
3. when clicking on an album, the "loading" message stays forever 

What is the expected output? What do you see instead?

What version of the product are you using? On what browser and version and
operating system?

PWI 1.5, on Safari 5.1 (Mac)

I have attached a modified demo13.html which shows the problem.

Original issue reported on code.google.com by marc.sau...@9online.fr on 30 Sep 2011 at 7:18

Attachments:

GoogleCodeExporter commented 9 years ago
Error reported by Firefox:

Error: $("<div id='permalinkenable' 
class='pwi_nextpage'/>").text(settings.labels.showPermaLink).bind is not a 
function
Source File: file:///E:/Picasa/pwi/trunk/jquery.pwi/js/jquery.pwi.js
Line: 433

Original comment by borkh...@gmail.com on 23 Oct 2011 at 3:40

GoogleCodeExporter commented 9 years ago
Fixed in SVN version 205, will be included in next release.

Current fix for this issue:
In jquery.pwi.js, replace line 17:
        opts = $.extend({}, $.fn.pwi.defaults, opts);
with:
        opts = $.extend(true,{}, $.fn.pwi.defaults, opts);

New minified version attached.

Original comment by borkh...@gmail.com on 4 Nov 2011 at 10:48

Attachments:

GoogleCodeExporter commented 9 years ago
Fix confirmed for me. Thanks

Original comment by marc.sau...@9online.fr on 4 Nov 2011 at 11:00