search

jsynowiec / vscode-insertdatestring

An extension for Visual Studio Code that provides a configurable command for inserting the current date and time
MIT License
63 stars 14 forks source link

TZ problem #12

Closed hsmyers closed 5 years ago

hsmyers commented 5 years ago

The extension is off-by-one in showing time on my machine. I live in a Mountain Daylight Savings zone, GMT-06 while you display -0700. My system variable is:

c:\>set TZ
tz=UTC-6
jsynowiec commented 5 years ago

This extension is using whatever time zone is available to the Node.js runtime, so effectively what's set on the host OS. I don't see how it could be off by an hour only on your computer (other than a problem with your OS configuration)

hsmyers commented 5 years ago

I thought that might be the case. I wonder about just that, the OS making the mistake. In any event, it isn't you or anyone else other than the OS so I'll begin to play around with the TZ settings and see what happens. Thanks for your attention, keep up the good work!

On Wed, May 29, 2019 at 1:24 AM Jakub Synowiec notifications@github.com wrote:

This extension is using whatever time zone is available to the Node.js runtime, so effectively what's set on the host OS. I don't see how it could be off by an hour only on your computer (other than a problem with your OS configuration)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jsynowiec/vscode-insertdatestring/issues/12?email_source=notifications&email_token=AAHE7PSXA5CYTOCSTV5IIQDPXYVRFA5CNFSM4HPIOLA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWONNHQ#issuecomment-496817822, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHE7PX7YHNX2WRW7DDLHLDPXYVRFANCNFSM4HPIOLAQ .

hsmyers commented 5 years ago

Found it! TZ=UTC-6 gives off by one error as mentioned. On the other hand TZ="Mountain Daylight Time" provides correct time all around.

On Wed, May 29, 2019 at 8:59 AM Hugh S. Myers hsmyers@gmail.com wrote:

I thought that might be the case. I wonder about just that, the OS making the mistake. In any event, it isn't you or anyone else other than the OS so I'll begin to play around with the TZ settings and see what happens. Thanks for your attention, keep up the good work!

On Wed, May 29, 2019 at 1:24 AM Jakub Synowiec notifications@github.com wrote:

This extension is using whatever time zone is available to the Node.js runtime, so effectively what's set on the host OS. I don't see how it could be off by an hour only on your computer (other than a problem with your OS configuration)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jsynowiec/vscode-insertdatestring/issues/12?email_source=notifications&email_token=AAHE7PSXA5CYTOCSTV5IIQDPXYVRFA5CNFSM4HPIOLA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWONNHQ#issuecomment-496817822, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHE7PX7YHNX2WRW7DDLHLDPXYVRFANCNFSM4HPIOLAQ .

jsynowiec commented 5 years ago

I think that you should set the TZ env var to a proper TZ name like Canada/Mountain, rather than the Mountain Daylight Time.

Glad you sorted it out. Closing.