search

jszopi / repESP

Reproducing molecular ESP from partial charges and more
GNU General Public License v3.0
6 stars 7 forks source link

CI: set up mypy check and add report to PR #35

Closed jszopi closed 5 years ago

jszopi commented 5 years ago

Replaces the last part of dev/checks.sh. In the script I've opted for snapshotting, ISTR there were some issues that were difficult to type: ignore or issues that I intended to solve, treating the snapshot as a backlog of type errors to be fixed.

jszopi commented 5 years ago

mypy now runs in CI. It's pass/fail, but I managed to get the codebase to a strict mypy level with a reeasonable number of type-ignore comments. I'll consider a coverage-like report for Any exprs, see https://github.com/jszopi/repESP/issues/44