search

jtackaberry / reaticulate

An articulation management system for REAPER
Other
101 stars 46 forks source link

Crash when parsing malformed Bank declaration #109

Closed pceniza closed 2 years ago

pceniza commented 4 years ago

Hi Tack, Im not sure if you can help but i hope so. I've recently encountered an issue with reaticulate whereby in the midi editor where you set the articulation programs it no longer gives me names for the articulations i've set. So it will be like 1-55-24 instead of 'marc' (articulation name i set). If i look under the bank list if i double click on that articulation, i've noticed quite a few of the recent additions i've made arent included in the list.

I've re-installed, currently at 0.4.5 but i also tried switching manually to 0.4.3 but that didnt help things. I'm not really sure what has gone wrong and what i else i can try. I'm not that script savvy with this btw, so im sure im missing something obvious.

Also.

I seem to have run into another issue.

.Data\Roaming\REAPER\Scripts\Reaticulate\app\reabank.lua:311: attempt to perform bitwise operation on a nil value (field 'msb')

i'm not sure what this means but Reaticulate currently won't load.

Please help if you can. Thanks. I posted on Vi Control forum aswell.

Regards, Patrick

jtackaberry commented 4 years ago

Hi @pceniza

This latter error is almost certainly the cause of the former. Can you please attach your user bank file here? Or if you're not comfortable sharing that publicly you can fire it over email too (tack@urandom.ca).

pceniza commented 4 years ago

Hi Tack, I had a chance this morning to look over the bank list again and i've since fixed the issue. It was a basic bank allocation and syntax error, had to touch base with your website and your comment of "the latter being the cause of of the former"...somehow clicked with me. I'm still getting my head around it all. Anyways, i really appreciate this tool and your effort!

jtackaberry commented 4 years ago

Thanks @pceniza for following up.

I'm going to rename this issue and keep it around because I consider the error you saw ("attempt to perform bitwise operation on a nil value") to be a bug even though the root cause was a syntax error in the bank. These things should be failing a lot more gracefully than that :)

jtackaberry commented 2 years ago

Reabank parsing saw significant changes in 0.5, and while I'm not sure of the exact syntax error that resulted in this bug, I'm pretty sure it's fixed. :)