search

jtackaberry / reaticulate

An articulation management system for REAPER
Other
101 stars 46 forks source link

Make articulation insertion compatible with undo #47

Closed Levitanus closed 5 years ago

Levitanus commented 6 years ago

I think it's consolidated with something else. When articulation is added by right-clicking, then immediately record starts, and after it undo is used, both, the recorded midi and pr change are removed.

jtackaberry commented 6 years ago

I can't reproduce this exactly, but there's always not been something quite right about the how Reaper handles undo with Reaticulate. It's something I've wrestled with, and I'm quite convinced there is at least one Reaper bug at play here, because despite neatly wrapping everything in Undo_BeginBlock2() and Undo_EndBlock2(), initiating an undo in Reaper will sometimes undo beyond the point of the Undo_BeginBlock2() call.

Levitanus commented 6 years ago

Yep, I've also noticed at my scripts) Still, I found a way of selecting the item between art assignment and record start. Not hard to keep in practice and works

jtackaberry commented 5 years ago

The redesign described by #62 will open the door to workarounds. I have a proof of concept working in my local tree so I'll tentative plan to fix this in the next major release (0.4.0).