jtalks-org / jtalks-vm

Virtual Machines configured by Vagrant (VirtualBox + Chef) in order to start environment for JTalks projects much faster and in a more repeatable manner.
1 stars 3 forks source link

Added cookbook name and version bump #3

Closed mrusan closed 10 years ago

mrusan commented 10 years ago

Hello,

This pull request fixes cookbook dependency resolution using Berkshelf.

Fetching 'tomcat7' from https://github.com/jtalks-org/jtalks-vm.git (at master/cookbooks/tomcat7)
Ridley::Errors::MissingNameAttribute The metadata at '/var/folders/6w/gk5wvlvn13bd9g4vpk20yvrr0000gn/T/d20140408-47229-1tnf1cd' does not contain a 'name' attribute. While Chef does not strictly enforce this requirement, Ridley cannot continue without a valid metadata 'name' entry.
ctapobep commented 10 years ago

Hi, @mrusan Thanks for your input! Could you please shed some light on the issue - how did you manage to reproduce it? Since we don't use Berkshelf (it doesn't support Vagrant anymore and therefore the berkshelf plugin doesn't work in the latest Vagrant versions), we don't have this warning. Did you try using these cookbooks in a different way?

mrusan commented 10 years ago

I'm using your tomcat cookbook separately in my project as it is the only cookbook I've found which can install tomcat from tarball and not install openjdk 6 as a dependency (I use oracle java).

All you need to do in order to reproduce this issue is to use the Berkshelf 3.0.0.beta gem and have that tomcat cookbook listed in the Berksfile - then berks install would give this error.

You might want to check the information about Berkshelf-Vargant compatibility. Berkshelf was not deprecated and works fine.

This is what I have installed:

$ berks -v
3.0.0.beta9
$ vagrant -v
Vagrant 1.4.3
$ kitchen -v
Test Kitchen version 1.2.1
ctapobep commented 10 years ago

Hehe, I see. I think we took this cookbook from this guy: https://github.com/gbloquel :)

Anyway, thanks for your changes and for info.

mrusan commented 10 years ago

Cheers ;)