jtamames / SqueezeMeta

A complete pipeline for metagenomic analysis
GNU General Public License v3.0
346 stars 81 forks source link

Error running Sequential mode with external assemblies #790

Closed r-frizzo closed 4 months ago

r-frizzo commented 4 months ago

Hello! I have found an issue when running the pipeline in sequential mode with external assemblies.

I've fixed issue #743 as you suggested, but then ran into another problem:

The external assembly path provided in the "samples" file is recognized, prompting the message: "External assembly provided: . Overriding assembly" then the path information is somehow lost, resulting in the message: "Can't find assembly file"

I think the error is around the if statement at line 71 of 01.run_all_assemblies.pl. I've changed line 72 from

$outassembly=$extassembly; 

to

$extassembly=$extassemblies{$asamples}; $outassembly=$extassembly;

and managed to get the pipeline going.

Would this work or would you suggest a better fix?

Thank you and have a nice evening, Riccardo

Screenshot from 2024-02-07 17-35-58

sequential_extassembly.zip

jtamames commented 4 months ago

Hello! I myself ran into this bug last week, and corrected it just as you did. Thank you for this! Best, J

r-frizzo commented 4 months ago

Awesome! Thank you!