jtart / react-universal-app

Library for building a single-page application with Universal React component(s) and React Router.
MIT License
14 stars 2 forks source link

An in-range update of react-router-dom is breaking the build 🚨 #87

Open greenkeeper[bot] opened 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency react-router-dom was updated from 4.3.1 to 4.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

react-router-dom is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **ci/circleci: integration-tests:** CircleCI is running your tests ([Details](https://circleci.com/gh/jtart/react-universal-app/568?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: app-tests:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/jtart/react-universal-app/567?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **coverage/coveralls:** First build on greenkeeper/react-universal-app/react-router-dom-4.4.0 at 100.0% ([Details](https://coveralls.io/builds/22218710)).

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

Your tests for group example-basic are passing again with this update. Explicitly upgrade example-basic to this version πŸš€

Commits

The new version differs by commits.

See the full diff

greenkeeper[bot] commented 5 years ago

After pinning to 4.3.1 your tests are passing again. Downgrade this dependency πŸ“Œ.