Change character constants to enums

jtauber / greek-accentuation

Python 3 library for accenting (and analyzing the accentuation of) Ancient Greek words

MIT License

56 stars 10 forks source link

Change character constants to enums #12

Closed bryanforbes closed 4 years ago

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling b0e87c563001ffec200ae99f2fd2586fa4375c07 on bryanforbes:use-enum into 568bada3480a02d71a84f1d97b3ce7c1e27745a0 on jtauber:master.

jtauber commented 4 years ago

sorry, I merged the other PR first. Can you update this to resolve the conflict? Also can you add yourself to the AUTHORS file?

jtauber commented 4 years ago

would also be good to add some comparison tests which, beside getting coverage % back up, would make sure the comparison you're doing is correct.

I presume the idea is that the Accentuation order based on mora location. That's worth documenting and testing.

bryanforbes commented 4 years ago

I added the comparison methods because sorted() requires __lt__ and adding only that method seemed incomplete. I'll add some tests in extra.rst to exercise them.