search

jtauber / pyuca

a Python implementation of the Unicode Collation Algorithm
MIT License
217 stars 23 forks source link

Shifted option for variable collation elements #17

Closed lucafavatella closed 7 years ago

lucafavatella commented 7 years ago

Depends on PRs #15 and #16 - both included in this PR.

This PR fixes all of the shifted tests.

jtauber commented 7 years ago

have you see my WIP settings branch (which is old and currently out of date)?

lucafavatella commented 7 years ago

have you see my WIP settings branch (which is old and currently out of date)?

@jtauber I had not - thanks for pointing that out. I see I did not duplicate work as only "non-ignorable" is supported in that branch - that is good.

One interesting thing I noticed in that branch is that it appears you removed the spurious trailing level separator, that had puzzled me (and I had explained with easier mapping to comments in conformance tests).

This week I may be able to revive that settings branch (maybe rebasing it on current master - keeping things like settings interface and doc), integrate my improvement in it and propose new PR (closing the open ones). Please ping me if you are faster!

lucafavatella commented 7 years ago

Will open new PR shortly including this work.