search

jtbandes / swift-tmlanguage

Swift language grammar for syntax highlighting
MIT License
7 stars 1 forks source link

Enums and other decls members have incorrect highlighting #10

Closed rauhul closed 8 months ago

rauhul commented 11 months ago

Firstly, thanks for maintaining this library!

I think a recent change broke how declaration members are rendered. If you take a look at this snippet from swift-mmio you can see the enum cases are highlighted incorrectly: https://github.com/apple/swift-mmio/blob/496ae117d5993036d0862e407fca9ada4f4270e5/Tests/MMIOFileCheckTests/FileCheck.swift#L12-L15

Screenshot 2023-12-15 at 8 24 47 PM
jtbandes commented 11 months ago

Thanks for the report. There must be some changes I made that are not working with GitHub's highlighter, but are working fine with VS Code. 😢

I'll try to look into these soon but unfortunately GitHub only updates their grammars to the latest version every few months, so it may be a while before it's fixed.

jtbandes commented 11 months ago

I believe this is an error with GitHub's highlighter; you can follow along at: https://github.com/github-linguist/linguist/issues/6668

jtbandes commented 8 months ago

The underlying issue with GitHub has been fixed. Sadly, GitHub is no longer using this tmLanguage grammar: https://github.com/github-linguist/linguist/issues/6668#issuecomment-1967867179

rauhul commented 8 months ago

Regardless of them switching over, truly thank you for keeping this grammar alive, it's been very helpful. I appreciate the time and effort you've put into making this :)