search

jtblin / angular-chart.js

Reactive, responsive, beautiful charts for AngularJS using Chart.js: http://jtblin.github.io/angular-chart.js
Other
2.67k stars 761 forks source link

tooltip label block color shows only the border without fill #414

Closed D4NH closed 8 years ago

D4NH commented 8 years ago

When hovering over a multiLine graph, the tooltip displays the labels where the blocks only have colored borders.

screen shot 2016-06-14 at 11 14 36

The example from ChartJS shows them filled.

screen shot 2016-06-14 at 11 15 19

Step to reproduce

http://plnkr.co/edit/dGKEKzNbk5YIXtkqM9oH?p=preview

Is there any setting to have them filled as the same color of the linegraph? Seems like the blockcolor in the tooltip fade away after loading the graph.

D4NH commented 8 years ago

found it at line 248, will try creating a Pull Request.

instead of:

247 ... 248 pointHoverBackgroundColor: '#fff', 249 ...

should be:

247 ... 248 pointHoverBackgroundColor: rgba(color, 1), 249 ...

D4NH commented 8 years ago

for some reason I can't commit my changes, getting:

Authentication failed for 'https://github.com/jtblin/angular-chart.js.git/' Pushing to https://github.com/jtblin/angular-chart.js.git 2016-06-15 09:30:54.909 git-credential-sourcetree[30939:8511127] Error (internetKeychainItemForServer:withUsername:path:port:protocol:) - The specified item could not be found in the keychain.

must be an issue in my system

jtblin commented 8 years ago

You need to fork the repo to send pull requests, you can't push to the repo directly.

On Wed, Jun 15, 2016 at 5:34 PM, Danh Nguyen notifications@github.com wrote:

for some reason I can't commit my changes, getting:

Authentication failed for 'https://github.com/jtblin/angular-chart.js.git/ ' Pushing to https://github.com/jtblin/angular-chart.js.git 2016-06-15 09:30:54.909 git-credential-sourcetree[30939:8511127] Error (internetKeychainItemForServer:withUsername:path:port:protocol:) - The specified item could not be found in the keychain.

must be an issue in my system

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jtblin/angular-chart.js/issues/414#issuecomment-226110714, or mute the thread https://github.com/notifications/unsubscribe/ABUxrmSgvnCXvXZpQtD4fmhOA7rc8Bcuks5qL6sXgaJpZM4I1HY9 .

D4NH commented 8 years ago

yes I did, but I cant push it:

screen shot 2016-06-15 at 10 06 38

remote: Permission to jtblin/angular-chart.js.git denied to D4NH. fatal: unable to access 'https://github.com/jtblin/angular-chart.js.git/': The requested URL returned error: 403

what the hell.. even with a personal access token (using 2factor)

jtblin commented 8 years ago

It looks like you're trying to push to my repo directly:

Pushing to https://github.com/jtblin/angular-chart.js.git

See https://help.github.com/articles/using-pull-requests/.

On Wed, Jun 15, 2016 at 6:07 PM, Danh Nguyen notifications@github.com wrote:

yes I did, but I cant push it:

[image: screen shot 2016-06-15 at 10 06 38] https://cloud.githubusercontent.com/assets/6664547/16072397/f2b1007e-32e0-11e6-92f7-680a01605767.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jtblin/angular-chart.js/issues/414#issuecomment-226117295, or mute the thread https://github.com/notifications/unsubscribe/ABUxrktzRcoPEHbw-v9u13a2pO0lwff2ks5qL7K8gaJpZM4I1HY9 .

jtblin commented 8 years ago

Merged, thanks for the PR.